Author: fanningpj
Date: Thu Sep 15 17:31:50 2022
New Revision: 1904092
URL: http://svn.apache.org/viewvc?rev=1904092&view=rev
Log:
lgtm issues
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/Switch.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Baseifs.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Roman.java
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/Switch.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/Switch.java?rev=1904092&r1=1904091&r2=1904092&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/Switch.java
(original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/Switch.java Thu
Sep 15 17:31:50 2022
@@ -56,7 +56,7 @@ public final class Switch implements Fre
return ErrorEval.NA;
}
- for (int i = 1; i < args.length; i = i+2) {
+ for (int i = 1; i < (args.length - 1); i += 2) {
try {
ValueEval value = OperandResolver.getSingleValue(args[i],
ec.getRowIndex(), ec.getColumnIndex());
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Baseifs.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Baseifs.java?rev=1904092&r1=1904091&r2=1904092&view=diff
==============================================================================
---
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Baseifs.java
(original)
+++
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Baseifs.java
Thu Sep 15 17:31:50 2022
@@ -67,7 +67,7 @@ import org.apache.poi.ss.formula.functio
// collect pairs of ranges and criteria
AreaEval[] ae = new AreaEval[(args.length - firstCriteria)/2];
I_MatchPredicate[] mp = new I_MatchPredicate[ae.length];
- for(int i = firstCriteria, k=0; i < args.length; i += 2, k++){
+ for(int i = firstCriteria, k=0; i < (args.length - 1); i += 2,
k++){
ae[k] = convertRangeArg(args[i]);
mp[k] = Countif.createCriteriaPredicate(args[i+1],
ec.getRowIndex(), ec.getColumnIndex());
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Roman.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Roman.java?rev=1904092&r1=1904091&r2=1904092&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Roman.java
(original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Roman.java
Thu Sep 15 17:31:50 2022
@@ -148,7 +148,7 @@ public class Roman extends Fixed2ArgFunc
continue;
}
String[] repl = REPLACEMENTS[i];
- for (int j=0; j<repl.length; j+=2) {
+ for (int j = 0; j < (repl.length - 1); j += 2) {
result = result.replace(repl[j],repl[j+1]);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
