Author: fanningpj
Date: Fri Jan 20 12:03:52 2023
New Revision: 1906836
URL: http://svn.apache.org/viewvc?rev=1906836&view=rev
Log:
[bug-66433] Boolean functions should blank cells. Thanks to Patrick Böker
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/BooleanFunction.java
poi/trunk/test-data/spreadsheet/BooleanFunctionsTestCaseData.xls
poi/trunk/test-data/spreadsheet/LookupFunctionsTestCaseData.xls
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/BooleanFunction.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/BooleanFunction.java?rev=1906836&r1=1906835&r2=1906836&view=diff
==============================================================================
---
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/BooleanFunction.java
(original)
+++
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/BooleanFunction.java
Fri Jan 20 12:03:52 2023
@@ -18,6 +18,7 @@
package org.apache.poi.ss.formula.functions;
import org.apache.poi.ss.formula.TwoDEval;
+import org.apache.poi.ss.formula.eval.BlankEval;
import org.apache.poi.ss.formula.eval.BoolEval;
import org.apache.poi.ss.formula.eval.ErrorEval;
import org.apache.poi.ss.formula.eval.EvaluationException;
@@ -91,7 +92,7 @@ public abstract class BooleanFunction im
continue;
}
- if (arg == MissingArgEval.instance) {
+ if (arg == MissingArgEval.instance || arg == BlankEval.instance) {
tempVe = false; // missing parameters are treated as FALSE
} else {
tempVe = OperandResolver.coerceValueToBoolean(arg, false);
Modified: poi/trunk/test-data/spreadsheet/BooleanFunctionsTestCaseData.xls
URL:
http://svn.apache.org/viewvc/poi/trunk/test-data/spreadsheet/BooleanFunctionsTestCaseData.xls?rev=1906836&r1=1906835&r2=1906836&view=diff
==============================================================================
Binary files - no diff available.
Modified: poi/trunk/test-data/spreadsheet/LookupFunctionsTestCaseData.xls
URL:
http://svn.apache.org/viewvc/poi/trunk/test-data/spreadsheet/LookupFunctionsTestCaseData.xls?rev=1906836&r1=1906835&r2=1906836&view=diff
==============================================================================
Binary files - no diff available.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]