svn commit: r1911891 - in /poi/trunk: poi-integration/src/test/java/org/apache/poi/stress/ poi-ooxml/src/test/java/org/apache/poi/openxml4j/ poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/ poi-scratchpad/src/main/java/org/apache/poi/hslf/us...

[centic]

Author: centic
Date: Thu Aug 24 08:53:01 2023
New Revision: 1911891

URL: http://svn.apache.org/viewvc?rev=1911891&view=rev
Log:
Apply some IDE suggestions, add tests, set unit-test to isolated

Without Isolation, one test did change static settings 
and thus could cause flaky tests

Modified:
    
poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XSSFFileHandler.java
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/TestOPCPackageFileLimit.java
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java
    
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java

Modified: 
poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XSSFFileHandler.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XSSFFileHandler.java?rev=1911891&r1=1911890&r2=1911891&view=diff
==============================================================================
--- 
poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XSSFFileHandler.java
 (original)
+++ 
poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XSSFFileHandler.java
 Thu Aug 24 08:53:01 2023
@@ -217,6 +217,8 @@ public class XSSFFileHandler extends Spr
         }
 
         handleExtracting(file);
+
+        handleAdditional(file);
     }
 
     @Test

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/TestOPCPackageFileLimit.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/TestOPCPackageFileLimit.java?rev=1911891&r1=1911890&r2=1911891&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/TestOPCPackageFileLimit.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/TestOPCPackageFileLimit.java
 Thu Aug 24 08:53:01 2023
@@ -22,6 +22,7 @@ import org.apache.poi.openxml4j.exceptio
 import org.apache.poi.openxml4j.opc.OPCPackage;
 import org.apache.poi.openxml4j.util.ZipSecureFile;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Isolated;
 
 import java.io.File;
 import java.io.IOException;
@@ -30,6 +31,7 @@ import java.io.InputStream;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
 
+@Isolated // changes static values, so other tests should not run at the same 
time
 class TestOPCPackageFileLimit {
     @Test
     void testWithReducedFileLimit() throws InvalidFormatException {

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java?rev=1911891&r1=1911890&r2=1911891&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java
 Thu Aug 24 08:53:01 2023
@@ -67,6 +67,12 @@ public final class TestReadOnlySharedStr
                     assertEquals(i1.getString(), 
rtbl.getItemAt(i).getString());
                     assertEquals(i1.getString(), 
rtbl2.getItemAt(i).getString());
                 }
+
+                // verify invalid indices
+                assertThrows(IllegalStateException.class,
+                        () -> rtbl.getItemAt(stbl.getUniqueCount()));
+                assertThrows(IndexOutOfBoundsException.class,
+                        () -> rtbl.getItemAt(-1));
             }
         }
     }

Modified: 
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java?rev=1911891&r1=1911890&r2=1911891&view=diff
==============================================================================
--- 
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java
 (original)
+++ 
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java
 Thu Aug 24 08:53:01 2023
@@ -1085,17 +1085,17 @@ public final class HSLFSlideShowImpl ext
         int count;
 
         @Override
-        public void write(int b) throws IOException {
+        public void write(int b) {
             count++;
         }
 
         @Override
-        public void write(byte[] b) throws IOException {
+        public void write(byte[] b) {
             count += b.length;
         }
 
         @Override
-        public void write(byte[] b, int off, int len) throws IOException {
+        public void write(byte[] b, int off, int len) {
             count += len;
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org