svn commit: r1912583 - in /poi/trunk: poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java

[fanningpj]

Author: fanningpj
Date: Thu Sep 28 22:35:00 2023
New Revision: 1912583

URL: http://svn.apache.org/viewvc?rev=1912583&view=rev
Log:
[github-523] set locales for some tests. This closes #523

Modified:
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
    
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java
    
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java?rev=1912583&r1=1912582&r2=1912583&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
 Thu Sep 28 22:35:00 2023
@@ -61,6 +61,8 @@ import org.apache.poi.xddf.usermodel.cha
 import org.apache.poi.xddf.usermodel.chart.XDDFChartData;
 import org.apache.poi.xssf.XSSFITestDataProvider;
 import org.apache.poi.xssf.model.StylesTable;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTCalcPr;
 import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTExternalLink;
@@ -79,6 +81,7 @@ import java.nio.charset.StandardCharsets
 import java.util.Date;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.zip.CRC32;
 
 import static org.apache.poi.hssf.HSSFTestDataSamples.openSampleFileStream;
@@ -100,6 +103,16 @@ public final class TestXSSFWorkbook exte
         super(XSSFITestDataProvider.instance);
     }
 
+    @BeforeAll
+    static void setUp() {
+        LocaleUtil.setUserLocale(Locale.US);
+    }
+
+    @AfterAll
+    static void tearDown() {
+        LocaleUtil.setUserLocale(null);
+    }
+
     /**
      * Tests that we can save, and then re-load a new document
      */

Modified: 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java?rev=1912583&r1=1912582&r2=1912583&view=diff
==============================================================================
--- 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java 
(original)
+++ 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java 
Thu Sep 28 22:35:00 2023
@@ -23,10 +23,14 @@ import org.apache.poi.hssf.usermodel.HSS
 import org.apache.poi.hssf.usermodel.HSSFWorkbook;
 import org.apache.poi.ss.usermodel.DateUtil;
 import org.apache.poi.ss.usermodel.FormulaError;
+import org.apache.poi.util.LocaleUtil;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
 import java.time.LocalDate;
+import java.util.Locale;
 
 import static org.apache.poi.ss.util.Utils.addRow;
 import static org.apache.poi.ss.util.Utils.assertDouble;
@@ -37,6 +41,16 @@ import static org.apache.poi.ss.util.Uti
  */
 public class TestDays {
 
+    @BeforeAll
+    static void setUp() {
+        LocaleUtil.setUserLocale(Locale.US);
+    }
+
+    @AfterAll
+    static void tearDown() {
+        LocaleUtil.setUserLocale(null);
+    }
+
     
//https://support.microsoft.com/en-us/office/days-function-57740535-d549-4395-8728-0f07bff0b9df
     @Test
     void testMicrosoftExample1() throws IOException {

Modified: 
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java?rev=1912583&r1=1912582&r2=1912583&view=diff
==============================================================================
--- 
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java 
(original)
+++ 
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestDataFormat.java 
Thu Sep 28 22:35:00 2023
@@ -22,8 +22,12 @@ import static org.junit.jupiter.api.Asse
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.io.IOException;
+import java.util.Locale;
 
 import org.apache.poi.ss.ITestDataProvider;
+import org.apache.poi.util.LocaleUtil;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -45,6 +49,16 @@ public abstract class BaseTestDataFormat
         assertEquals(-1, BuiltinFormats.getBuiltinFormat(customFmt));
     }
 
+    @BeforeAll
+    static void setUp() {
+        LocaleUtil.setUserLocale(Locale.US);
+    }
+
+    @AfterAll
+    static void tearDown() {
+        LocaleUtil.setUserLocale(null);
+    }
+
     @Test
     public final void testBuiltinFormats() throws IOException {
         try (Workbook wb = _testDataProvider.createWorkbook()) {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org