Author: centic
Date: Tue Oct 3 06:17:01 2023
New Revision: 1912709
URL: http://svn.apache.org/viewvc?rev=1912709&view=rev
Log:
Assert that deleting test-files and entries works in tests
Modified:
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFUnicodeSurrogates.java
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFUnicodeSurrogates.java
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java
poi/trunk/poi/src/test/java/org/apache/poi/poifs/filesystem/TestPOIFSStream.java
Modified:
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFUnicodeSurrogates.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFUnicodeSurrogates.java?rev=1912709&r1=1912708&r2=1912709&view=diff
==============================================================================
---
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFUnicodeSurrogates.java
(original)
+++
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFUnicodeSurrogates.java
Tue Oct 3 06:17:01 2023
@@ -18,6 +18,7 @@
package org.apache.poi.xssf.streaming;
import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.Row;
@@ -62,7 +63,7 @@ class TestSXSSFUnicodeSurrogates {
assertEquals(unicodeText, cell2.getStringCellValue());
}
} finally {
- tf.delete();
+ assertTrue(tf.delete());
}
}
}
Modified:
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFUnicodeSurrogates.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFUnicodeSurrogates.java?rev=1912709&r1=1912708&r2=1912709&view=diff
==============================================================================
---
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFUnicodeSurrogates.java
(original)
+++
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFUnicodeSurrogates.java
Tue Oct 3 06:17:01 2023
@@ -18,6 +18,7 @@
package org.apache.poi.xssf.usermodel;
import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.Row;
@@ -61,7 +62,7 @@ class TestXSSFUnicodeSurrogates {
assertEquals(unicodeText, cell2.getStringCellValue());
}
} finally {
- tf.delete();
+ assertTrue(tf.delete());
}
}
}
Modified:
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java?rev=1912709&r1=1912708&r2=1912709&view=diff
==============================================================================
---
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
(original)
+++
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
Tue Oct 3 06:17:01 2023
@@ -1479,7 +1479,7 @@ public final class TestXSSFWorkbook exte
}
assertEquals(2, count);
} finally {
- tempFile.delete();
+ assertTrue(tempFile.delete());
}
}
Modified:
poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java?rev=1912709&r1=1912708&r2=1912709&view=diff
==============================================================================
---
poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java
(original)
+++
poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java
Tue Oct 3 06:17:01 2023
@@ -19,6 +19,7 @@ package org.apache.poi.hssf.usermodel;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
import java.io.ByteArrayInputStream;
import java.io.IOException;
@@ -89,7 +90,7 @@ class TestPOIFSProperties {
summary1.setTitle(title);
//write the modified property back to POIFS
-
fs.getRoot().getEntryCaseInsensitive(SummaryInformation.DEFAULT_STREAM_NAME).delete();
+
assertTrue(fs.getRoot().getEntryCaseInsensitive(SummaryInformation.DEFAULT_STREAM_NAME).delete());
fs.createDocument(summary1.toInputStream(),
SummaryInformation.DEFAULT_STREAM_NAME);
// check that the information was added successfully to the filesystem
object
Modified:
poi/trunk/poi/src/test/java/org/apache/poi/poifs/filesystem/TestPOIFSStream.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/poifs/filesystem/TestPOIFSStream.java?rev=1912709&r1=1912708&r2=1912709&view=diff
==============================================================================
---
poi/trunk/poi/src/test/java/org/apache/poi/poifs/filesystem/TestPOIFSStream.java
(original)
+++
poi/trunk/poi/src/test/java/org/apache/poi/poifs/filesystem/TestPOIFSStream.java
Tue Oct 3 06:17:01 2023
@@ -1817,7 +1817,7 @@ final class TestPOIFSStream {
main4096[4095] = -11;
testDir.createDocument("Normal4096", new
ByteArrayInputStream(main4096));
- root.getEntryCaseInsensitive("Tags").delete();
+
assertTrue(root.getEntryCaseInsensitive("Tags").delete());
// Write out, re-load
@@ -1848,7 +1848,7 @@ final class TestPOIFSStream {
// Delete a directory, and add one more
- testDir.getEntryCaseInsensitive("Testing
456").delete();
+
assertTrue(testDir.getEntryCaseInsensitive("Testing 456").delete());
testDir.createDirectory("Testing ABC");
@@ -1903,7 +1903,7 @@ final class TestPOIFSStream {
// Delete a mini stream, add one more
-
testDir.getEntryCaseInsensitive("Mini").delete();
+
assertTrue(testDir.getEntryCaseInsensitive("Mini").delete());
byte[] mini3 = new byte[]{42, 0, 42, 0,
42, 0, 42};
testDir.createDocument("Mini3", new
ByteArrayInputStream(mini3));
@@ -2179,8 +2179,8 @@ final class TestPOIFSStream {
// Delete a couple of streams
- miniDoc.delete();
- normDoc.delete();
+ assertTrue(miniDoc.delete());
+ assertTrue(normDoc.delete());
// Check - will have un-used sectors now
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
