Author: fanningpj
Date: Tue Oct 17 10:34:23 2023
New Revision: 1913056

URL: http://svn.apache.org/viewvc?rev=1913056&view=rev
Log:
refactor

Modified:
    
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java

Modified: 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java?rev=1913056&r1=1913055&r2=1913056&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java
 Tue Oct 17 10:34:23 2023
@@ -61,7 +61,8 @@ public abstract class BaseXSSFFormulaEva
         try {
             EvaluationCell evalCell = toEvaluationCell(cell);
             eval = _bookEvaluator.evaluate(evalCell);
-            cacheExternalWorkbookCells(evalCell);
+            if (evalCell instanceof XSSFEvaluationCell)
+                cacheExternalWorkbookCells((XSSFEvaluationCell) evalCell);
         } catch (IllegalStateException e) {
             // enhance IllegalStateException which can be
             // thrown somewhere deep down the evaluation
@@ -103,7 +104,7 @@ public abstract class BaseXSSFFormulaEva
      *
      * @param evalCell sourceCell
      */
-    private void cacheExternalWorkbookCells(EvaluationCell evalCell) {
+    private void cacheExternalWorkbookCells(XSSFEvaluationCell evalCell) {
         //
         Ptg[] formulaTokens = 
getEvaluationWorkbook().getFormulaTokens(evalCell);
         for (Ptg ptg : formulaTokens) {
@@ -112,7 +113,7 @@ public abstract class BaseXSSFFormulaEva
                 if (area3DPxg.getExternalWorkbookNumber() > 0) {
                     EvaluationWorkbook.ExternalSheet externalSheet = 
getEvaluationWorkbook().getExternalSheet(area3DPxg.getSheetName(), 
area3DPxg.getLastSheetName(), area3DPxg.getExternalWorkbookNumber());
                     if (externalSheet != null) {
-                        processEvalCell((XSSFEvaluationCell) evalCell, 
externalSheet, area3DPxg);
+                        processEvalCell(evalCell, externalSheet, area3DPxg);
                     }
                 }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to