svn commit: r1913651 - in /poi/trunk: poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/ poi/src/test/java/org/apache/poi/ss/usermodel/

[fanningpj]

Author: fanningpj
Date: Tue Nov  7 12:23:53 2023
New Revision: 1913651

URL: http://svn.apache.org/viewvc?rev=1913651&view=rev
Log:
try to fix broken sxssf tests

Modified:
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
    poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java
    
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java?rev=1913651&r1=1913650&r2=1913651&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java
 Tue Nov  7 12:23:53 2023
@@ -165,10 +165,7 @@ class TestSXSSFCell extends BaseTestXCel
     protected void 
setCellFormula_onASingleCellArrayFormulaCell_preservesTheValue() {
     }
 
-    @Disabled
-    protected void setCellFormula_isExceptionSafe_onBlankCell() {
-    }
-
+    @Override
     @Disabled
     protected void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() {
     }

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java?rev=1913651&r1=1913650&r2=1913651&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
 Tue Nov  7 12:23:53 2023
@@ -48,7 +48,10 @@ public final class TestSXSSFFormulaEvalu
         super(SXSSFITestDataProvider.instance);
     }
 
-    void testSharedFormulas() throws IOException {
+
+    @Override
+    @Disabled
+    protected void testSharedFormulas() throws IOException {
         /* not implemented */
     }
 

Modified: 
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java?rev=1913651&r1=1913650&r2=1913651&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java 
(original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java 
Tue Nov  7 12:23:53 2023
@@ -1408,7 +1408,7 @@ public abstract class BaseTestCell {
     }
 
     @Test
-    void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() throws 
IOException {
+    protected void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() 
throws IOException {
         try (Workbook wb = _testDataProvider.createWorkbook()) {
             Cell cell = getInstance(wb);
             cell.getSheet().setArrayFormula("3", 
CellRangeAddress.valueOf("A1:A2"));

Modified: 
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java?rev=1913651&r1=1913650&r2=1913651&view=diff
==============================================================================
--- 
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java
 (original)
+++ 
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java
 Tue Nov  7 12:23:53 2023
@@ -117,7 +117,7 @@ public abstract class BaseTestFormulaEva
     }
 
     @Test
-    void testSharedFormulas() throws IOException {
+    protected void testSharedFormulas() throws IOException {
         String fileName = "shared_formulas.xls" + 
(getClass().getName().contains("xssf") ? "x" : "");
         try (Workbook wb = _testDataProvider.openSampleWorkbook(fileName)) {
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org