Author: centic Date: Sat Dec 30 11:11:21 2023 New Revision: 1914986 URL: http://svn.apache.org/viewvc?rev=1914986&view=rev Log: Don't fail on JDK 21.0.1 if one signature check fails
See https://bugs.openjdk.org/browse/JDK-8320597 for the related bug-report for the JDK itself Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java?rev=1914986&r1=1914985&r2=1914986&view=diff ============================================================================== --- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java (original) +++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java Sat Dec 30 11:11:21 2023 @@ -253,9 +253,15 @@ class TestSignatureInfo { si.setSignatureConfig(sic); boolean isValid = si.verifySignature(); + // We reported https://bugs.openjdk.org/browse/JDK-8320597 because of this, it will be fixed in JDK 22 + // and maybe in newer JDK 21 patch-levels + assumeTrue(isValid && !"21.0.1".equals(System.getProperty("java.version")), + "This fails on JDK 21.0.1, see https://bugs.openjdk.org/browse/JDK-8320597";); + assertTrue(isValid, // add some details to find out why "verifySignature()" returns false sometimes - "Verifying signature failed, hasNext: " + si.getSignatureParts().iterator().hasNext() + ": " + + "Failed for " + System.getProperty("java.version") + + ": Verifying signature failed, hasNext: " + si.getSignatureParts().iterator().hasNext() + ": " + (si.getSignatureParts().iterator().hasNext() ? si.getSignatureParts().iterator() : "")); } } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
