svn commit: r1918397 - /poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java

[fanningpj]

Author: fanningpj
Date: Mon Jun 17 21:37:36 2024
New Revision: 1918397

URL: http://svn.apache.org/viewvc?rev=1918397&view=rev
Log:
issue with Java 22 returning string values insteadof booleans

Modified:
    poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java

Modified: poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java?rev=1918397&r1=1918396&r2=1918397&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java 
(original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java Mon Jun 
17 21:37:36 2024
@@ -36,6 +36,7 @@ import javax.xml.parsers.DocumentBuilder
 import javax.xml.stream.XMLInputFactory;
 import javax.xml.stream.XMLOutputFactory;
 
+import org.junit.jupiter.api.Assumptions;
 import org.junit.jupiter.api.Test;
 import org.xml.sax.InputSource;
 import org.xml.sax.SAXNotRecognizedException;
@@ -136,12 +137,12 @@ class TestXMLHelper {
     @Test
     void testNewXMLInputFactory() {
         XMLInputFactory factory = XMLHelper.newXMLInputFactory();
-        if (!System.getProperty("java.version").startsWith("22")) {
-            assertEquals(Boolean.TRUE, 
factory.getProperty(XMLInputFactory.IS_NAMESPACE_AWARE));
-            assertEquals(Boolean.FALSE, 
factory.getProperty(XMLInputFactory.IS_VALIDATING));
-            assertEquals(Boolean.FALSE, 
factory.getProperty(XMLInputFactory.SUPPORT_DTD));
-            assertEquals(Boolean.FALSE, 
factory.getProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES));
-        }
+        
Assumptions.assumeFalse(System.getProperty("java.version").startsWith("22"),
+            "test ignored for Java 22");
+        assertEquals(Boolean.TRUE, 
factory.getProperty(XMLInputFactory.IS_NAMESPACE_AWARE));
+        assertEquals(Boolean.FALSE, 
factory.getProperty(XMLInputFactory.IS_VALIDATING));
+        assertEquals(Boolean.FALSE, 
factory.getProperty(XMLInputFactory.SUPPORT_DTD));
+        assertEquals(Boolean.FALSE, 
factory.getProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES));
     }
 
     /**
@@ -150,9 +151,9 @@ class TestXMLHelper {
     @Test
     void testNewXMLOutputFactory() {
         XMLOutputFactory factory = XMLHelper.newXMLOutputFactory();
-        if (!System.getProperty("java.version").startsWith("22")) {
-            assertEquals(Boolean.TRUE, 
factory.getProperty(XMLOutputFactory.IS_REPAIRING_NAMESPACES));
-        }
+        
Assumptions.assumeFalse(System.getProperty("java.version").startsWith("22"),
+            "test ignored for Java 22");
+        assertEquals(Boolean.TRUE, 
factory.getProperty(XMLOutputFactory.IS_REPAIRING_NAMESPACES));
     }
 
     /**



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org