Author: fanningpj
Date: Sat May 17 16:02:13 2025
New Revision: 1925647
URL: http://svn.apache.org/viewvc?rev=1925647&view=rev
Log:
code refactor
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/TextObjectRecord.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Rept.java
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/TextObjectRecord.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/TextObjectRecord.java?rev=1925647&r1=1925646&r2=1925647&view=diff
==============================================================================
---
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/TextObjectRecord.java
(original)
+++
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/TextObjectRecord.java
Sat May 17 16:02:13 2025
@@ -212,7 +212,7 @@ public final class TextObjectRecord exte
protected void serialize(ContinuableRecordOutput out) {
serializeTXORecord(out);
- if (_text.getString().length() > 0) {
+ if (_text.length() == 0) {
serializeTrailingRecords(out);
}
}
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Rept.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Rept.java?rev=1925647&r1=1925646&r2=1925647&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Rept.java
(original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Rept.java
Sat May 17 16:02:13 2025
@@ -40,7 +40,6 @@ import org.apache.poi.ss.formula.eval.Va
*/
public class Rept extends Fixed2ArgFunction {
-
@Override
public ValueEval evaluate(int srcRowIndex, int srcColumnIndex, ValueEval
text, ValueEval number_times) {
@@ -64,7 +63,7 @@ public class Rept extends Fixed2ArgFunct
strb.append(strText1);
}
- if (strb.toString().length() > 32767) {
+ if (strb.length() > 32767) {
return ErrorEval.VALUE_INVALID;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
