(poi) branch trunk updated: refactor

[fanningpj]

This is an automated email from the ASF dual-hosted git repository.

pjfanning pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/poi.git


The following commit(s) were added to refs/heads/trunk by this push:
     new ab27e10173 refactor
ab27e10173 is described below

commit ab27e10173f1cf9cb8408c6c6da5c402fcd23a92
Author: PJ Fanning <pjfann...@users.noreply.github.com>
AuthorDate: Wed Jun 3 20:14:36 2026 +0100

    refactor
---
 .../src/test/java/org/apache/poi/xssf/XSSFITestDataProvider.java    | 6 +++---
 poi/src/test/java/org/apache/poi/hssf/HSSFITestDataProvider.java    | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git 
a/poi-ooxml/src/test/java/org/apache/poi/xssf/XSSFITestDataProvider.java 
b/poi-ooxml/src/test/java/org/apache/poi/xssf/XSSFITestDataProvider.java
index 6876b9b61f..c63152d501 100644
--- a/poi-ooxml/src/test/java/org/apache/poi/xssf/XSSFITestDataProvider.java
+++ b/poi-ooxml/src/test/java/org/apache/poi/xssf/XSSFITestDataProvider.java
@@ -26,6 +26,8 @@ import org.apache.poi.ss.usermodel.Workbook;
 import org.apache.poi.xssf.usermodel.XSSFFormulaEvaluator;
 import org.apache.poi.xssf.usermodel.XSSFWorkbook;
 
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+
 public final class XSSFITestDataProvider implements ITestDataProvider {
     public static final XSSFITestDataProvider instance = new 
XSSFITestDataProvider();
 
@@ -40,9 +42,7 @@ public final class XSSFITestDataProvider implements 
ITestDataProvider {
 
     @Override
     public XSSFWorkbook writeOutAndReadBack(Workbook original) {
-        if(!(original instanceof XSSFWorkbook)) {
-            throw new IllegalArgumentException("Expected an instance of 
XSSFWorkbook, but had " + original.getClass());
-        }
+        assertInstanceOf(XSSFWorkbook.class, original, "Expected an instance 
of XSSFWorkbook");
         return XSSFTestDataSamples.writeOutAndReadBack((XSSFWorkbook)original);
     }
 
diff --git a/poi/src/test/java/org/apache/poi/hssf/HSSFITestDataProvider.java 
b/poi/src/test/java/org/apache/poi/hssf/HSSFITestDataProvider.java
index 9f073c1fa5..4700c2e642 100644
--- a/poi/src/test/java/org/apache/poi/hssf/HSSFITestDataProvider.java
+++ b/poi/src/test/java/org/apache/poi/hssf/HSSFITestDataProvider.java
@@ -28,6 +28,8 @@ import org.apache.poi.ss.usermodel.FormulaEvaluator;
 import org.apache.poi.ss.usermodel.Sheet;
 import org.apache.poi.ss.usermodel.Workbook;
 
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+
 public final class HSSFITestDataProvider implements ITestDataProvider {
     public static final HSSFITestDataProvider instance = new 
HSSFITestDataProvider();
 
@@ -46,9 +48,7 @@ public final class HSSFITestDataProvider implements 
ITestDataProvider {
 
     @Override
     public HSSFWorkbook writeOutAndReadBack(Workbook original) {
-        if(!(original instanceof HSSFWorkbook)) {
-            throw new IllegalArgumentException("Expected an instance of 
HSSFWorkbook");
-        }
+        assertInstanceOf(HSSFWorkbook.class, original, "Expected an instance 
of HSSFWorkbook");
         return HSSFTestDataSamples.writeOutAndReadBack((HSSFWorkbook)original);
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org