flyrain commented on code in PR #198: URL: https://github.com/apache/polaris/pull/198#discussion_r1729305274
########## .github/pull_request_template.md: ########## @@ -34,7 +34,4 @@ Please delete options that are not relevant. - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings -- [ ] I have added tests that prove my fix is effective or that my feature works -- [ ] New and existing unit tests pass locally with my changes Review Comment: I think it isn't necessary as we got the github pipeline, which should pass strictly to be able to merge ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
