rdsarvar commented on issue #85:
URL: https://github.com/apache/polaris/issues/85#issuecomment-2309033250
@flyrain QQ about the repo which I noticed starting to write the changes
required by this MR:
1. Do the regtests have Open API Python templates that aren't commit into
the repo? When I generate the files with the provided commands in the README it
results in generated Python files without the license header and in some cases
it breaks the functionality. An example diff of
`regtests/client/python/polaris/management/models/aws_storage_config_info.py`:
```
_obj = cls.model_validate({
"storageType": obj.get("storageType"),
- "allowedLocations": obj.get("allowedLocations"),
- "roleArn": obj.get("roleArn")
+ "allowedLocations": obj.get("allowedLocations")
})
```
2. I was thinking about how to add integration / e2e tests and noticed that
there isn't really any integration tests (outside of
polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java),
do we rely on the e2e tests for testing against the storage providers? --
Curious to what your preference would be for this repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
