RussellSpitzer commented on code in PR #199:
URL: https://github.com/apache/polaris/pull/199#discussion_r1730972806


##########
regtests/run_spark_sql.sh:
##########
@@ -13,11 +13,19 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
+# -----------------------------------------------------------------------------
+# Purpose: Launch the Spark SQL shell to interact with Polaris.
+# -----------------------------------------------------------------------------
 #
+# Usage:
+#   Without arguments: Uses local filesystem.
+#   With two arguments: Uses S3.

Review Comment:
   we should probably do a real usage string rather than this,
   
   usage: ./run_spark_sql.sh [s3-path aws-role]
   
   s3-path: Location on S3 to .....
   aws-role: arn?role? used for authenticating catalog?client?both?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to