dimas-b opened a new pull request, #211:
URL: https://github.com/apache/polaris/pull/211
# Description
Iceberg REST API spec defines two possible values for the
`X-Iceberg-Access-Delegation`:
* vended-credentials
* remote-signing
This change fixes Polaris docs to use the `vended-credentials` value instead
of previous (incorrect) value of `true` and makes the REST API service validate
the `X-Iceberg-Access-Delegation` header submitted by the client against the
spec.
Note: since old docs suggested invalid `X-Iceberg-Access-Delegation` header
values (the string `true`), clients configured according to the old docs will
_not_ be able to connect to the updated servers. Technically this is a breaking
change, but it is necessary to align to the REST API spec. The old suggested
value of `true` cannot be interpreted according to the spec, so it will result
in error responses to the misconfigured clients.
Detailed changes:
* Add `AccessDelegationMode` enum to parse and represent specified
delegation modes in java.
* Update `IcebergCatalogAdapter` to validate that if access
delegation is supported by the client, that "vended-credentials"
is accepted ("remote-signing" is not supported by the server).
* Remove unused method parameters.
* Re-generate docs
## Type of change
Please delete options that are not relevant.
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Documentation update
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] This change requires a documentation update
# How Has This Been Tested?
Existing and new unit tests
# Checklist:
Please delete options that are not relevant.
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
