This is an automated email from the ASF dual-hosted git repository.
snazy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new 2effb23 Enable ErrorProne FallThrough, MissingCasesInEnumSwitch,
OrphanedFormatString (#202)
2effb23 is described below
commit 2effb23f9596aa62ddf0a2a8be8be9e12f51d6bd
Author: Yuya Ebihara <[email protected]>
AuthorDate: Tue Aug 27 16:14:20 2024 +0900
Enable ErrorProne FallThrough, MissingCasesInEnumSwitch,
OrphanedFormatString (#202)
---
build-logic/src/main/kotlin/polaris-java.gradle.kts | 3 +++
.../java/org/apache/polaris/service/catalog/BasePolarisCatalog.java | 2 ++
2 files changed, 5 insertions(+)
diff --git a/build-logic/src/main/kotlin/polaris-java.gradle.kts
b/build-logic/src/main/kotlin/polaris-java.gradle.kts
index 4a91766..d046221 100644
--- a/build-logic/src/main/kotlin/polaris-java.gradle.kts
+++ b/build-logic/src/main/kotlin/polaris-java.gradle.kts
@@ -36,7 +36,10 @@ tasks.withType(JavaCompile::class.java).configureEach {
options.errorprone.disableWarningsInGeneratedCode = true
options.errorprone.error(
"DefaultCharset",
+ "FallThrough",
+ "MissingCasesInEnumSwitch",
"MissingOverride",
+ "OrphanedFormatString",
"StringCaseLocaleUsage",
)
}
diff --git
a/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java
b/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java
index be0d5e3..2d81876 100644
---
a/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java
+++
b/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java
@@ -1646,6 +1646,8 @@ public class BasePolarisCatalog extends
BaseMetastoreViewCatalog
throw new AlreadyExistsException(
"Cannot rename %s to %s. View already exists", from, to);
}
+ throw new IllegalStateException(
+ String.format("Unexpected entity type '%s'",
existingEntitySubType));
}
case PolarisMetaStoreManager.ReturnStatus.ENTITY_NOT_FOUND:
