dennishuo commented on code in PR #211:
URL: https://github.com/apache/polaris/pull/211#discussion_r1733332111
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##########
@@ -171,28 +173,39 @@ public Response updateProperties(
.build();
}
+ private EnumSet<AccessDelegationMode> parseAccessDelegationModes(String
accessDelegationMode) {
+ EnumSet<AccessDelegationMode> delegationModes =
+ AccessDelegationMode.fromProtocolValuesList(accessDelegationMode);
+ if (!delegationModes.isEmpty() &&
!delegationModes.contains(VENDED_CREDENTIALS)) {
Review Comment:
Makes sense, I think that's a decent tradeoff for now since "true" was
unfortunately exposed through docs for awhile so this would facilitate
migrating some initial proofs-of-concept for now.
I agree with having strict validation in general, and agree erroring on
unsupported `remote-signing` or any other invalid values for now is a good idea
since it's easier to relax such behaviors than tighten in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
