nk1506 commented on code in PR #216:
URL: https://github.com/apache/polaris/pull/216#discussion_r1733363067
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1143,12 +1143,19 @@ private class BasePolarisCatalogViewBuilder extends
BaseMetastoreViewCatalog.Bas
public BasePolarisCatalogViewBuilder(TableIdentifier identifier) {
super(identifier);
+ withProperties(viewDefaultProperties());
}
@Override
public ViewBuilder withLocation(String newLocation) {
return super.withLocation(transformTableLikeLocation(newLocation));
}
+
+ private Map<String, String> viewDefaultProperties() {
+ Map<String, String> viewDefaultProperties =
PropertyUtil.propertiesWithPrefix(BasePolarisCatalog.this.properties(),
"table-default.");
+ LOGGER.info("View properties set at catalog level through catalog
properties: {}", viewDefaultProperties);
Review Comment:
Thanks @sfc-gh-emaynard for reviewing.
Do you think it might log any sensitive message? Since catalog properties
could have some kind of credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
