jbonofre commented on code in PR #42: URL: https://github.com/apache/polaris/pull/42#discussion_r1738715951
########## getting-started/docker-compose-trino.yml: ########## @@ -0,0 +1,59 @@ +# +# Copyright (c) 2024 Snowflake Computing Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +services: + polaris: + build: + context: .. + ports: + - "8181:8181" + - "8182" + environment: + AWS_REGION: us-west-2 + GOOGLE_APPLICATION_CREDENTIALS: $GOOGLE_APPLICATION_CREDENTIALS + AZURE_TENANT_ID: $AZURE_TENANT_ID + AZURE_CLIENT_ID: $AZURE_CLIENT_ID + AZURE_CLIENT_SECRET: $AZURE_CLIENT_SECRET + command: # override the command to specify aws keys as dropwizard config + - java + - -Ddw.awsAccessKey=$AWS_ACCESS_KEY_ID + - -Ddw.awsSecretKey=$AWS_SECRET_ACCESS_KEY + - -jar + - /app/polaris-service-1.0.0-all.jar + - server + - polaris-server.yml + + healthcheck: + test: ["CMD", "curl", "http://localhost:8182/healthcheck";] + interval: 10s + timeout: 10s + retries: 5 + + create-catalog: + image: curlimages/curl + depends_on: + polaris: + condition: service_healthy + volumes: + - ./create-catalog.sh:/create-catalog.sh + command: ["/bin/sh", "/create-catalog.sh"] + + trino: + image: trinodb/trino:latest Review Comment: In order to not privilege one engine from other, I would propose to create an `engine` folder in the `getting-started` one. We can add `trino`, `spark`, `flink`, `doris`, `dremio`, etc there. ########## getting-started/trino-config/catalog/iceberg.properties: ########## @@ -0,0 +1,21 @@ +# +# Copyright (c) 2024 Snowflake Computing Inc. Review Comment: Please use ASF header here. ########## getting-started/trino-config/jvm.config: ########## @@ -0,0 +1,31 @@ +# +# Copyright (c) 2024 Snowflake Computing Inc. Review Comment: Please use ASF header here. ########## getting-started/trino-config/node.properties: ########## @@ -0,0 +1,17 @@ +# +# Copyright (c) 2024 Snowflake Computing Inc. Review Comment: Please use ASF header here. ########## getting-started/create-catalog.sh: ########## @@ -0,0 +1,37 @@ +# +# Copyright (c) 2024 Snowflake Computing Inc. Review Comment: Please use ASF header there. ########## getting-started/trino-config/config.properties: ########## @@ -0,0 +1,20 @@ +# +# Copyright (c) 2024 Snowflake Computing Inc. Review Comment: Please use ASF header here. ########## getting-started/docker-compose-trino.yml: ########## @@ -0,0 +1,59 @@ +# +# Copyright (c) 2024 Snowflake Computing Inc. Review Comment: Same here, please use the ASF header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
