aihuaxu commented on code in PR #158:
URL: https://github.com/apache/polaris/pull/158#discussion_r1742420146
##########
polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java:
##########
@@ -288,7 +289,7 @@ public void run(PolarisApplicationConfig configuration,
Environment environment)
// different processes
// and in-memory state will be lost b/w invocation of bootstrap command
and running a server
if (metaStoreManagerFactory instanceof
InMemoryPolarisMetaStoreManagerFactory) {
-
metaStoreManagerFactory.getOrCreateMetaStoreManager(configuration::getDefaultRealm);
+
metaStoreManagerFactory.bootstrapRealms(List.of(configuration.getDefaultRealm()));
}
Review Comment:
I reverted the change actually since the users actually rely on the output
to get the credentials from console.
##########
polaris-service/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -48,40 +40,4 @@ protected PolarisMetaStoreSession createMetaStoreSession(
@NotNull PolarisTreeMapStore store, @NotNull RealmContext realmContext) {
return new PolarisTreeMapMetaStoreSessionImpl(store, storageIntegration);
}
-
- @Override
- public synchronized PolarisMetaStoreManager getOrCreateMetaStoreManager(
- RealmContext realmContext) {
- String realmId = realmContext.getRealmIdentifier();
- if (!bootstrappedRealms.contains(realmId)) {
- bootstrapRealmAndPrintCredentials(realmId);
- }
- return super.getOrCreateMetaStoreManager(realmContext);
- }
Review Comment:
I brought back the change now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
