eric-maynard commented on code in PR #243:
URL: https://github.com/apache/polaris/pull/243#discussion_r1742512814
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -257,6 +259,12 @@ public <T> T runInTransaction(
} finally {
localSession.remove();
}
+ } catch (PersistenceException e) {
+ if (e.toString().toLowerCase(Locale.ROOT).contains("duplicate key")) {
+ throw new IllegalStateException("Duplicate key error when persisting
entity", e);
Review Comment:
`PersistenceException` is not visible in the service, and Iceberg's
`AlreadyExistsException` is not visible here. It might be ideal to introduce
our own exception mapper with our own exceptions kept in polaris-core, but
that's a big migration.
For now, I'm using this `IllegalStateException` to negotiate between the two
exception types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
