dennishuo commented on code in PR #270:
URL: https://github.com/apache/polaris/pull/270#discussion_r1746601123
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManagerImpl.java:
##########
@@ -1502,6 +1506,26 @@ public Map<String, String>
deserializeProperties(PolarisCallContext callCtx, Str
}
}
+ // Check that cleanup is enabled, if it is set:
+ if (catalogPath != null && cleanup) {
+ boolean dropWithPurgeEnabled =
+ callCtx
+ .getConfigurationStore()
+ .getConfiguration(
+ callCtx,
+ (CatalogEntity) catalogPath.get(0),
+ PolarisConfiguration.DROP_WITH_PURGE_ENABLED);
+ if (dropWithPurgeEnabled) {
Review Comment:
Yeah that's a good point, I'm okay with FORBIDDEN after re-reading the RFC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
