eric-maynard commented on code in PR #264:
URL: https://github.com/apache/polaris/pull/264#discussion_r1746666244
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1298,7 +1302,12 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
validateLocationsForTableLike(tableIdentifier, dataLocations,
resolvedStorageEntity);
// also validate that the table location doesn't overlap an existing
table
dataLocations.forEach(
- location -> validateNoLocationOverlap(tableIdentifier,
resolvedNamespace, location));
+ location ->
+ validateNoLocationOverlap(
+
CatalogEntity.of(resolvedStorageEntity.getRawFullPath().getFirst()),
Review Comment:
Good callout, I will replace this where possible. I won't necessarily hunt
down the existing usages though, so we should still go back and refactor at
some point.
Eventually I would like to see something a little more structured than a
list of entities
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
