snazy commented on code in PR #268:
URL: https://github.com/apache/polaris/pull/268#discussion_r1759185094
##########
gradle/projects.main.properties:
##########
@@ -22,3 +22,4 @@ polaris-core=polaris-core
polaris-service=polaris-service
polaris-eclipselink=extension/persistence/eclipselink
aggregated-license-report=aggregated-license-report
+polaris-docker=docker
Review Comment:
Hm - can you move `docker/` to somewhere else or use a nested folder
structure?
I could imagine that there'll be more docker related things.
##########
.github/workflows/regtest.yml:
##########
@@ -33,10 +33,28 @@ jobs:
steps:
- uses: actions/checkout@v4
+
+ - name: Set up JDK 21
+ uses: actions/setup-java@v4
+ with:
+ java-version: '21'
+ distribution: 'temurin'
+
+ # Configure Gradle for optimal use in GiHub Actions, including caching
of downloaded dependencies.
+ # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
+ - name: Setup Gradle
+ uses:
gradle/actions/setup-gradle@16bf8bc8fe830fa669c3c9f914d3eb147c629707 # v4
+ with:
+ # The setup-gradle action fails, if the wrapper is not using the
right version or is not present.
+ # Our `gradlew` validates the integrity of the `gradle-wrapper.jar`,
so it's safe to disable this.
+ validate-wrappers: false
+
- name: fix permissions
run: mkdir -p regtests/output && chmod 777 regtests/output && chmod
777 regtests/t_*/ref/*
- name: Regression Test
env:
AWS_ACCESS_KEY_ID: ${{secrets.AWS_ACCESS_KEY_ID}}
AWS_SECRET_ACCESS_KEY: ${{secrets.AWS_SECRET_ACCESS_KEY}}
- run: docker compose up --build --exit-code-from regtest
+ run: |
+ ./gradlew dockerBuild --info
Review Comment:
Nit:
```suggestion
./gradlew dockerBuild --stacktrace
```
##########
polaris-service/build.gradle.kts:
##########
@@ -247,11 +247,16 @@ val startScripts =
classpath = files(provider { shadowJar.get().archiveFileName })
}
-tasks.register<Sync>("prepareDockerDist") {
- into(project.layout.buildDirectory.dir("docker-dist"))
- from(startScripts) { into("bin") }
- from(shadowJar) { into("lib") }
- doFirst { delete(project.layout.buildDirectory.dir("regtest-dist")) }
-}
+val prepareDockerDist =
+ tasks.register<Sync>("prepareDockerDist") {
+ into(project.layout.buildDirectory.dir("docker-dist"))
+ from(startScripts) { into("bin") }
+ from(shadowJar) { into("lib") }
+ doFirst { delete(project.layout.buildDirectory.dir("regtest-dist")) }
Review Comment:
```suggestion
doFirst { delete(project.layout.buildDirectory.dir("docker-dist")) }
```
However, the delete shouldn't be necessary, singe it's a `Sync` task. Can
you verify this and if that's true remove this `doFirst`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
