dennishuo commented on PR #322: URL: https://github.com/apache/polaris/pull/322#issuecomment-2375795140
Good suggestion, bumped up to 9999. In theory 100 might "accidentally" exercise the backoff once in awhile, but thinking about it more we should be more explicit if we really want to exercise the actual 429 errors anyways, and it'd be fragile to just balance the limit at some number just on the boundary, since tests change over time. I think it's still reasonable to keep the rate limiter in the mix to exercise at least the initialization and "happy path" of not hitting limits for these "end-to-end integration tests" so that all components are there working together. 9999 should be good for being a not-infinite but effectively infinite limit given the round-trip overhead of these end-to-end calls aren't expected to be able to do more than 10 per millisecond anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
