This is an automated email from the ASF dual-hosted git repository.
ebyhr pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new 49ec2c96 Remove unused method (#384)
49ec2c96 is described below
commit 49ec2c96cfa6e02e68ac85818574695542ae7887
Author: Yuya Ebihara <[email protected]>
AuthorDate: Sat Oct 19 10:24:08 2024 +0900
Remove unused method (#384)
---
.../apache/polaris/core/storage/PolarisStorageIntegration.java | 9 ---------
.../core/storage/aws/AwsCredentialsStorageIntegration.java | 8 --------
.../core/storage/azure/AzureCredentialsStorageIntegration.java | 7 -------
.../core/storage/gcp/GcpCredentialsStorageIntegration.java | 7 -------
.../polaris/core/storage/InMemoryStorageIntegrationTest.java | 7 -------
.../service/storage/PolarisStorageIntegrationProviderImpl.java | 7 -------
6 files changed, 45 deletions(-)
diff --git
a/polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java
b/polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java
index 21249c99..97bbc8a2 100644
---
a/polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java
+++
b/polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java
@@ -61,15 +61,6 @@ public abstract class PolarisStorageIntegration<T extends
PolarisStorageConfigur
@NotNull Set<String> allowedReadLocations,
@NotNull Set<String> allowedWriteLocations);
- /**
- * Describe the configuration for the current storage integration.
- *
- * @param storageConfigInfo the configuration info provided by the user.
- * @return an enum map
- */
- public abstract EnumMap<PolarisStorageConfigurationInfo.DescribeProperty,
String>
- descPolarisStorageConfiguration(@NotNull PolarisStorageConfigurationInfo
storageConfigInfo);
-
/**
* Validate access for the provided operation actions and locations.
*
diff --git
a/polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java
b/polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java
index 32e028d0..1714f67c 100644
---
a/polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java
+++
b/polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java
@@ -27,7 +27,6 @@ import java.util.stream.Stream;
import org.apache.polaris.core.PolarisDiagnostics;
import org.apache.polaris.core.storage.InMemoryStorageIntegration;
import org.apache.polaris.core.storage.PolarisCredentialProperty;
-import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo;
import org.apache.polaris.core.storage.StorageUtil;
import org.jetbrains.annotations.NotNull;
import software.amazon.awssdk.policybuilder.iam.IamConditionOperator;
@@ -187,11 +186,4 @@ public class AwsCredentialsStorageIntegration
}
return path;
}
-
- // FIXME - we don't need this method in the interface
- @Override
- public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
- descPolarisStorageConfiguration(@NotNull PolarisStorageConfigurationInfo
storageConfigInfo) {
- return null;
- }
}
diff --git
a/polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java
b/polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java
index ce7ca5b0..86888c41 100644
---
a/polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java
+++
b/polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java
@@ -47,7 +47,6 @@ import java.util.Set;
import org.apache.polaris.core.PolarisDiagnostics;
import org.apache.polaris.core.storage.InMemoryStorageIntegration;
import org.apache.polaris.core.storage.PolarisCredentialProperty;
-import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo;
import org.jetbrains.annotations.NotNull;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -273,10 +272,4 @@ public class AzureCredentialsStorageIntegration
}
return accessToken;
}
-
- @Override
- public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
- descPolarisStorageConfiguration(@NotNull PolarisStorageConfigurationInfo
storageConfigInfo) {
- return null;
- }
}
diff --git
a/polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java
b/polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java
index 30569092..5e0d7e04 100644
---
a/polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java
+++
b/polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java
@@ -39,7 +39,6 @@ import java.util.stream.Stream;
import org.apache.polaris.core.PolarisDiagnostics;
import org.apache.polaris.core.storage.InMemoryStorageIntegration;
import org.apache.polaris.core.storage.PolarisCredentialProperty;
-import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo;
import org.apache.polaris.core.storage.PolarisStorageIntegration;
import org.apache.polaris.core.storage.StorageUtil;
import org.jetbrains.annotations.NotNull;
@@ -207,10 +206,4 @@ public class GcpCredentialsStorageIntegration
private static String bucketResource(String bucket) {
return "//storage.googleapis.com/projects/_/buckets/" + bucket;
}
-
- @Override
- public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
- descPolarisStorageConfiguration(@NotNull PolarisStorageConfigurationInfo
storageConfigInfo) {
- return null;
- }
}
diff --git
a/polaris-core/src/test/java/org/apache/polaris/core/storage/InMemoryStorageIntegrationTest.java
b/polaris-core/src/test/java/org/apache/polaris/core/storage/InMemoryStorageIntegrationTest.java
index 1039f83a..14656e35 100644
---
a/polaris-core/src/test/java/org/apache/polaris/core/storage/InMemoryStorageIntegrationTest.java
+++
b/polaris-core/src/test/java/org/apache/polaris/core/storage/InMemoryStorageIntegrationTest.java
@@ -197,12 +197,5 @@ class InMemoryStorageIntegrationTest {
@NotNull Set<String> allowedWriteLocations) {
return null;
}
-
- @Override
- public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty, String>
- descPolarisStorageConfiguration(
- @NotNull PolarisStorageConfigurationInfo storageConfigInfo) {
- return null;
- }
}
}
diff --git
a/polaris-service/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java
b/polaris-service/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java
index 579ef033..b3252a29 100644
---
a/polaris-service/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java
+++
b/polaris-service/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java
@@ -90,13 +90,6 @@ public class PolarisStorageIntegrationProviderImpl
implements PolarisStorageInte
return new EnumMap<>(PolarisCredentialProperty.class);
}
- @Override
- public EnumMap<PolarisStorageConfigurationInfo.DescribeProperty,
String>
- descPolarisStorageConfiguration(
- @NotNull PolarisStorageConfigurationInfo
storageConfigInfo) {
- return new
EnumMap<>(PolarisStorageConfigurationInfo.DescribeProperty.class);
- }
-
@Override
public @NotNull Map<String, Map<PolarisStorageActions,
ValidationResult>>
validateAccessToLocations(
