This is an automated email from the ASF dual-hosted git repository.
adutra pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new 51a45377 Fix "too many open files" error when running integration
tests (#800)
51a45377 is described below
commit 51a4537733c95fba7eb409cfa384e1a355bb0130
Author: Alexandre Dutra <[email protected]>
AuthorDate: Thu Jan 16 13:09:46 2025 +0100
Fix "too many open files" error when running integration tests (#800)
This was due to the fact that each token fetch created a new client, and
the client wasn't closed.
---
.../main/java/org/apache/polaris/service/it/env/PolarisClient.java | 2 +-
.../java/org/apache/polaris/service/it/ext/PolarisServerManager.java | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/integration-tests/src/main/java/org/apache/polaris/service/it/env/PolarisClient.java
b/integration-tests/src/main/java/org/apache/polaris/service/it/env/PolarisClient.java
index e0c2f38e..b4fce998 100644
---
a/integration-tests/src/main/java/org/apache/polaris/service/it/env/PolarisClient.java
+++
b/integration-tests/src/main/java/org/apache/polaris/service/it/env/PolarisClient.java
@@ -115,7 +115,7 @@ public final class PolarisClient implements AutoCloseable {
/** Requests an access token from the Polaris server for the given {@link
ClientCredentials}. */
public String obtainToken(ClientCredentials credentials) {
- return polarisServerManager().accessManager().obtainAccessToken(endpoints,
credentials);
+ return
polarisServerManager().accessManager(client).obtainAccessToken(endpoints,
credentials);
}
private boolean ownedName(String name) {
diff --git
a/integration-tests/src/main/java/org/apache/polaris/service/it/ext/PolarisServerManager.java
b/integration-tests/src/main/java/org/apache/polaris/service/it/ext/PolarisServerManager.java
index 00cb8828..85e99e0c 100644
---
a/integration-tests/src/main/java/org/apache/polaris/service/it/ext/PolarisServerManager.java
+++
b/integration-tests/src/main/java/org/apache/polaris/service/it/ext/PolarisServerManager.java
@@ -51,8 +51,8 @@ public interface PolarisServerManager {
*/
Server serverForContext(ExtensionContext context);
- default PolarisAccessManager accessManager() {
- return new IcebergTokenAccessManager(createClient());
+ default PolarisAccessManager accessManager(Client client) {
+ return new IcebergTokenAccessManager(client);
}
/** Create a new HTTP client for accessing the server targeted by tests. */