This is an automated email from the ASF dual-hosted git repository.
yufei pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new 3ceffdff7 CLI: Remove the trailing comma (#2863)
3ceffdff7 is described below
commit 3ceffdff7c35958926adfec2aa3bd310a06ddc53
Author: Yufei Gu <[email protected]>
AuthorDate: Wed Oct 22 15:15:06 2025 -0700
CLI: Remove the trailing comma (#2863)
---
client/python/cli/command/__init__.py | 2 +-
client/python/test/test_cli_parsing.py | 13 ++++++++++++-
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/client/python/cli/command/__init__.py
b/client/python/cli/command/__init__.py
index 4463649c2..8a7d3d84c 100644
--- a/client/python/cli/command/__init__.py
+++ b/client/python/cli/command/__init__.py
@@ -40,7 +40,7 @@ class Command(ABC):
set_properties =
Parser.parse_properties(options_get(Arguments.SET_PROPERTY))
remove_properties = options_get(Arguments.REMOVE_PROPERTY)
catalog_client_scopes = options_get(Arguments.CATALOG_CLIENT_SCOPE)
- parameters =
Parser.parse_properties(options_get(Arguments.PARAMETERS)),
+ parameters = Parser.parse_properties(options_get(Arguments.PARAMETERS))
command = None
if options.command == Commands.CATALOGS:
diff --git a/client/python/test/test_cli_parsing.py
b/client/python/test/test_cli_parsing.py
index 1cca75e2f..af5f8e28b 100644
--- a/client/python/test/test_cli_parsing.py
+++ b/client/python/test/test_cli_parsing.py
@@ -618,6 +618,17 @@ class TestCliParsing(unittest.TestCase):
(1, 'client_secret'): 'e469c048cf866dfae469c048cf866df1',
})
+ def test_policies_attach_parameters_parsed_to_dict(self):
+ options = Parser.parse([
+ 'policies', 'attach', 'policy-name',
+ '--catalog', 'cat',
+ '--attachment-type', 'catalog',
+ '--parameters', 'key=value',
+ ])
+ command = Command.from_options(options)
+ self.assertIsInstance(command.parameters, dict)
+ self.assertEqual({'key': 'value'}, command.parameters)
+
if __name__ == '__main__':
- unittest.main()
\ No newline at end of file
+ unittest.main()
