(polaris) branch main updated: Test-fix: Cleanup OPA test container on stop (#3041)

[singhpk234]

This is an automated email from the ASF dual-hosted git repository.

singhpk234 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new 57accd1d6 Test-fix: Cleanup OPA test container on stop (#3041)
57accd1d6 is described below

commit 57accd1d6fa9a6030ef6cb8119f410da23a09c01
Author: Robert Stupp <sn...@snazy.de>
AuthorDate: Mon Nov 17 08:17:11 2025 +0100

    Test-fix: Cleanup OPA test container on stop (#3041)
    
    Quarkus takes care of reusing a test-resource across tests. The current 
behavior leaves the container around.
    
    Plus some nit-fixes (deprecation + local var)
---
 .../polaris/extension/auth/opa/test/OpaTestResource.java      | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git 
a/extensions/auth/opa/tests/src/intTest/java/org/apache/polaris/extension/auth/opa/test/OpaTestResource.java
 
b/extensions/auth/opa/tests/src/intTest/java/org/apache/polaris/extension/auth/opa/test/OpaTestResource.java
index 0bc0385b9..3a3f3cd9d 100644
--- 
a/extensions/auth/opa/tests/src/intTest/java/org/apache/polaris/extension/auth/opa/test/OpaTestResource.java
+++ 
b/extensions/auth/opa/tests/src/intTest/java/org/apache/polaris/extension/auth/opa/test/OpaTestResource.java
@@ -21,6 +21,7 @@ package org.apache.polaris.extension.auth.opa.test;
 import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
 import java.io.OutputStream;
 import java.net.HttpURLConnection;
+import java.net.URI;
 import java.net.URL;
 import java.nio.charset.StandardCharsets;
 import java.time.Duration;
@@ -32,8 +33,8 @@ import org.testcontainers.containers.wait.strategy.Wait;
 
 public class OpaTestResource implements QuarkusTestResourceLifecycleManager {
   private static GenericContainer<?> opa;
-  private int mappedPort;
 
+  @SuppressWarnings({"resource", "HttpUrlsUsage"})
   @Override
   public Map<String, String> start() {
     try {
@@ -55,7 +56,7 @@ public class OpaTestResource implements 
QuarkusTestResourceLifecycleManager {
         opa.start();
       }
 
-      mappedPort = opa.getMappedPort(8181);
+      int mappedPort = opa.getMappedPort(8181);
       String containerHost = opa.getHost();
       String baseUrl = "http://"; + containerHost + ":" + mappedPort;
 
@@ -92,7 +93,7 @@ public class OpaTestResource implements 
QuarkusTestResourceLifecycleManager {
   private void loadRegoPolicy(String baseUrl, String policyName, String 
regoPolicy) {
     // Hardcode the policy directly instead of loading through 
QuarkusTestProfile
     try {
-      URL url = new URL(baseUrl + "/v1/policies/" + policyName);
+      URL url = URI.create(baseUrl + "/v1/policies/" + policyName).toURL();
       System.out.println("Uploading policy to: " + url);
 
       HttpURLConnection conn = (HttpURLConnection) url.openConnection();
@@ -125,7 +126,7 @@ public class OpaTestResource implements 
QuarkusTestResourceLifecycleManager {
 
   @Override
   public void stop() {
-    // Don't stop the container to allow reuse across tests
-    // Container will be cleaned up when the JVM exits
+    // Quarkus takes care of reusing the test resource across tests
+    opa.stop();
   }
 }