This is an automated email from the ASF dual-hosted git repository.
snazy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new 7071543b5 Remove unused polarisEventListener field from
IcebergCatalogHandler (#3045)
7071543b5 is described below
commit 7071543b5a81f78891e5c78172aeee13a77e4b28
Author: Christopher Lambert <[email protected]>
AuthorDate: Mon Nov 17 09:11:18 2025 +0100
Remove unused polarisEventListener field from IcebergCatalogHandler (#3045)
it was added in c3f5001d4ec8bc7db43d3293056400ae73f84a9b but then its
only usage was removed in d03c7174ccf6771a0673e02b5e6d691d6cca9419
---
.../polaris/service/catalog/iceberg/IcebergCatalogAdapter.java | 5 -----
.../polaris/service/catalog/iceberg/IcebergCatalogHandler.java | 4 ----
.../service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java | 4 ----
.../iceberg/IcebergCatalogHandlerFineGrainedDisabledTest.java | 1 -
.../testFixtures/java/org/apache/polaris/service/TestServices.java | 1 -
5 files changed, 15 deletions(-)
diff --git
a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java
b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java
index 352d1a81c..1101ccbee 100644
---
a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java
+++
b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java
@@ -84,7 +84,6 @@ import
org.apache.polaris.service.catalog.common.CatalogAdapter;
import org.apache.polaris.service.catalog.io.StorageAccessConfigProvider;
import org.apache.polaris.service.config.ReservedProperties;
import org.apache.polaris.service.context.catalog.CallContextCatalogFactory;
-import org.apache.polaris.service.events.listeners.PolarisEventListener;
import org.apache.polaris.service.http.IcebergHttpUtil;
import org.apache.polaris.service.http.IfNoneMatch;
import org.apache.polaris.service.reporting.PolarisMetricsReporter;
@@ -149,7 +148,6 @@ public class IcebergCatalogAdapter
private final ReservedProperties reservedProperties;
private final CatalogHandlerUtils catalogHandlerUtils;
private final Instance<ExternalCatalogFactory> externalCatalogFactories;
- private final PolarisEventListener polarisEventListener;
private final StorageAccessConfigProvider storageAccessConfigProvider;
private final PolarisMetricsReporter metricsReporter;
@@ -168,7 +166,6 @@ public class IcebergCatalogAdapter
ReservedProperties reservedProperties,
CatalogHandlerUtils catalogHandlerUtils,
@Any Instance<ExternalCatalogFactory> externalCatalogFactories,
- PolarisEventListener polarisEventListener,
StorageAccessConfigProvider storageAccessConfigProvider,
PolarisMetricsReporter metricsReporter) {
this.diagnostics = diagnostics;
@@ -185,7 +182,6 @@ public class IcebergCatalogAdapter
this.reservedProperties = reservedProperties;
this.catalogHandlerUtils = catalogHandlerUtils;
this.externalCatalogFactories = externalCatalogFactories;
- this.polarisEventListener = polarisEventListener;
this.storageAccessConfigProvider = storageAccessConfigProvider;
this.metricsReporter = metricsReporter;
}
@@ -227,7 +223,6 @@ public class IcebergCatalogAdapter
reservedProperties,
catalogHandlerUtils,
externalCatalogFactories,
- polarisEventListener,
storageAccessConfigProvider);
}
diff --git
a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
index d2e48d2cc..4f4ab0d1d 100644
---
a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
+++
b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
@@ -109,7 +109,6 @@ import
org.apache.polaris.service.catalog.common.CatalogUtils;
import org.apache.polaris.service.catalog.io.StorageAccessConfigProvider;
import org.apache.polaris.service.config.ReservedProperties;
import org.apache.polaris.service.context.catalog.CallContextCatalogFactory;
-import org.apache.polaris.service.events.listeners.PolarisEventListener;
import org.apache.polaris.service.http.IcebergHttpUtil;
import org.apache.polaris.service.http.IfNoneMatch;
import org.apache.polaris.service.types.NotificationRequest;
@@ -138,7 +137,6 @@ public class IcebergCatalogHandler extends CatalogHandler
implements AutoCloseab
private final CallContextCatalogFactory catalogFactory;
private final ReservedProperties reservedProperties;
private final CatalogHandlerUtils catalogHandlerUtils;
- private final PolarisEventListener polarisEventListener;
private final StorageAccessConfigProvider storageAccessConfigProvider;
// Catalog instance will be initialized after authorizing resolver
successfully resolves
@@ -163,7 +161,6 @@ public class IcebergCatalogHandler extends CatalogHandler
implements AutoCloseab
ReservedProperties reservedProperties,
CatalogHandlerUtils catalogHandlerUtils,
Instance<ExternalCatalogFactory> externalCatalogFactories,
- PolarisEventListener polarisEventListener,
StorageAccessConfigProvider storageAccessConfigProvider) {
super(
diagnostics,
@@ -178,7 +175,6 @@ public class IcebergCatalogHandler extends CatalogHandler
implements AutoCloseab
this.catalogFactory = catalogFactory;
this.reservedProperties = reservedProperties;
this.catalogHandlerUtils = catalogHandlerUtils;
- this.polarisEventListener = polarisEventListener;
this.storageAccessConfigProvider = storageAccessConfigProvider;
}
diff --git
a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java
b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java
index 34118d6a7..037057521 100644
---
a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java
+++
b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java
@@ -133,7 +133,6 @@ public class IcebergCatalogHandlerAuthzTest extends
PolarisAuthzTestBase {
reservedProperties,
catalogHandlerUtils,
emptyExternalCatalogFactory(),
- polarisEventListener,
storageAccessConfigProvider);
}
@@ -273,7 +272,6 @@ public class IcebergCatalogHandlerAuthzTest extends
PolarisAuthzTestBase {
reservedProperties,
catalogHandlerUtils,
emptyExternalCatalogFactory(),
- polarisEventListener,
storageAccessConfigProvider);
// a variety of actions are all disallowed because the principal's
credentials must be rotated
@@ -311,7 +309,6 @@ public class IcebergCatalogHandlerAuthzTest extends
PolarisAuthzTestBase {
reservedProperties,
catalogHandlerUtils,
emptyExternalCatalogFactory(),
- polarisEventListener,
storageAccessConfigProvider);
doTestSufficientPrivilegeSets(
@@ -1188,7 +1185,6 @@ public class IcebergCatalogHandlerAuthzTest extends
PolarisAuthzTestBase {
reservedProperties,
catalogHandlerUtils,
emptyExternalCatalogFactory(),
- polarisEventListener,
storageAccessConfigProvider);
}
diff --git
a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerFineGrainedDisabledTest.java
b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerFineGrainedDisabledTest.java
index 0b4fcc910..cc59fb088 100644
---
a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerFineGrainedDisabledTest.java
+++
b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerFineGrainedDisabledTest.java
@@ -70,7 +70,6 @@ public class IcebergCatalogHandlerFineGrainedDisabledTest
extends PolarisAuthzTe
reservedProperties,
catalogHandlerUtils,
emptyExternalCatalogFactory(),
- polarisEventListener,
storageAccessConfigProvider);
}
diff --git
a/runtime/service/src/testFixtures/java/org/apache/polaris/service/TestServices.java
b/runtime/service/src/testFixtures/java/org/apache/polaris/service/TestServices.java
index 4c910ffbd..3d40493f8 100644
---
a/runtime/service/src/testFixtures/java/org/apache/polaris/service/TestServices.java
+++
b/runtime/service/src/testFixtures/java/org/apache/polaris/service/TestServices.java
@@ -319,7 +319,6 @@ public record TestServices(
reservedProperties,
catalogHandlerUtils,
externalCatalogFactory,
- polarisEventListener,
storageAccessConfigProvider,
new DefaultMetricsReporter());
