This is an automated email from the ASF dual-hosted git repository.

snazy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new 6f5145acf Fix integration-tests after #3704 (#3711)
6f5145acf is described below

commit 6f5145acf7df348f6846d0cbaaa07da702b684ec
Author: Robert Stupp <[email protected]>
AuthorDate: Mon Feb 9 17:02:40 2026 +0100

    Fix integration-tests after #3704 (#3711)
    
    Short story: This change fixes the int-tests in `:polaris-runtime-service`.
    
    Long story is this:
    In `:polaris-runtime-service` we intentionally declare "just" a 
`platform(libs.quarkus.bom)` dependency, because of the 
`:polaris-spark-integration-*` module.
    It is however generally recommended by Quarkus to _only_ use 
`enforcedPlatform(libs.quarkus.bom)` to effectively prevent breaking changes 
coming from transitive dependencies. Which is exactly what happend after #3704.
    
    Why did CI not catch this issue?
    The answer is pretty simple: The effective Gradle task inputs, including 
the `intTestRuntimeClasspath` did not change. So the previously cached test 
outcomes could be reused, and the int-tests did not run.
    Just adding the `runtimeClasspath` as another task-input of the `intTest` 
may _not_ work as intended.
    
    Why does _removing_ `implementation(platform(libs.opentelemetry.bom))` help?
    Simply because that lets the dependencies fall back to to the declared 
transitive dependencies. We do not have direct dependencies to OTel.
    
    The correct fix here _would_ be to use 
`implementation(enforcedPlatform(libs.quarkus.bom))`, but that breaks the Spark 
plugin integration tests.
    
    There is a better alternative: Let the Spark plugin tests leverage 
polaris-apprunner, which is meant for exactly the use case of effectively 
decoupling some module from the build requirements of a Quarkus application.
---
 gradle/libs.versions.toml        | 1 -
 runtime/service/build.gradle.kts | 2 --
 2 files changed, 3 deletions(-)

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 828c8a325..c8d0fd212 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -83,7 +83,6 @@ microprofile-fault-tolerance-api = { module = 
"org.eclipse.microprofile.fault-to
 mockito-core = { module = "org.mockito:mockito-core", version = "5.21.0" }
 mockito-junit-jupiter = { module = "org.mockito:mockito-junit-jupiter", 
version = "5.21.0" }
 mongodb-driver-sync = { module = "org.mongodb:mongodb-driver-sync", version = 
"5.6.3" }
-opentelemetry-bom = { module = "io.opentelemetry:opentelemetry-bom", version = 
"1.59.0" }
 opentelemetry-instrumentation-bom-alpha = { module = 
"io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha", 
version= "2.20.1-alpha" }
 picocli = { module = "info.picocli:picocli-codegen", version.ref = "picocli" }
 picocli-codegen = { module = "info.picocli:picocli-codegen", version.ref = 
"picocli" }
diff --git a/runtime/service/build.gradle.kts b/runtime/service/build.gradle.kts
index 1218cb183..8d50454ba 100644
--- a/runtime/service/build.gradle.kts
+++ b/runtime/service/build.gradle.kts
@@ -50,8 +50,6 @@ dependencies {
   implementation("org.apache.iceberg:iceberg-core")
   implementation("org.apache.iceberg:iceberg-aws")
 
-  implementation(platform(libs.opentelemetry.bom))
-
   implementation(platform(libs.quarkus.bom))
   implementation("io.quarkus:quarkus-logging-json")
   implementation("io.quarkus:quarkus-rest-jackson")

Reply via email to