This is an automated email from the ASF dual-hosted git repository.

snazy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new a67df4b69 CI: Do not consider "skipped" as "successful" (#3868)
a67df4b69 is described below

commit a67df4b699356646f9b61078bff0b09ce8f8bdc0
Author: Robert Stupp <[email protected]>
AuthorDate: Tue Feb 24 08:38:55 2026 +0100

    CI: Do not consider "skipped" as "successful" (#3868)
---
 .github/workflows/ci.yml | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c96e9140f..b2c06b74d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -403,6 +403,17 @@ jobs:
       - regtest
       - markdown-link-check
       - site
+    # Always run this job, even if a "needed" job fails. Without this one, 
GitHub will not run
+    # this job and that yields "Success" to the branch protection rule, which 
is wrong.
+    # Potential results for each "needed" job are: `success`, `failure`, 
`cancelled`, `skipped`.
+    # We consider `success` and `skipped` as "ok", `failure` and `cancelled` 
as "not ok".
+    if: ${{ always() }}
     runs-on: ubuntu-24.04
     steps:
-      - run: echo "All checks passed"
+      - run: |
+          if [[ "${{ join(needs.*.result, ',') }}" =~ .*(failure|cancelled).* 
]]; then
+            echo "At least one check failed"
+            exit 1
+          else
+            echo "All checks passed"
+          fi

Reply via email to