This is an automated email from the ASF dual-hosted git repository.
shimamoto pushed a commit to branch develop
in repository
https://gitbox.apache.org/repos/asf/predictionio-template-similar-product.git
The following commit(s) were added to refs/heads/develop by this push:
new 3e3317b Mark override methods
new 19c60ee Merge pull request #20 from takezoe/mark-override
3e3317b is described below
commit 3e3317b966ab60d8ba8cba6e529e6ef923104b62
Author: Naoki Takezoe <[email protected]>
AuthorDate: Thu May 30 20:21:20 2019 +0900
Mark override methods
---
src/main/scala/ALSAlgorithm.scala | 2 ++
src/main/scala/CooccurrenceAlgorithm.scala | 2 ++
src/main/scala/Preparator.scala | 1 +
3 files changed, 5 insertions(+)
diff --git a/src/main/scala/ALSAlgorithm.scala
b/src/main/scala/ALSAlgorithm.scala
index 3c48561..c23559f 100644
--- a/src/main/scala/ALSAlgorithm.scala
+++ b/src/main/scala/ALSAlgorithm.scala
@@ -44,6 +44,7 @@ class ALSAlgorithm(val ap: ALSAlgorithmParams)
@transient lazy val logger = Logger[this.type]
+ override
def train(sc: SparkContext, data: PreparedData): ALSModel = {
require(!data.viewEvents.take(1).isEmpty,
s"viewEvents in PreparedData cannot be empty." +
@@ -115,6 +116,7 @@ class ALSAlgorithm(val ap: ALSAlgorithmParams)
)
}
+ override
def predict(model: ALSModel, query: Query): PredictedResult = {
val productFeatures = model.productFeatures
diff --git a/src/main/scala/CooccurrenceAlgorithm.scala
b/src/main/scala/CooccurrenceAlgorithm.scala
index c6e0e08..6f238ae 100644
--- a/src/main/scala/CooccurrenceAlgorithm.scala
+++ b/src/main/scala/CooccurrenceAlgorithm.scala
@@ -27,6 +27,7 @@ class CooccurrenceModel(
class CooccurrenceAlgorithm(val ap: CooccurrenceAlgorithmParams)
extends P2LAlgorithm[PreparedData, CooccurrenceModel, Query,
PredictedResult] {
+ override
def train(sc: SparkContext, data: PreparedData): CooccurrenceModel = {
val itemStringIntMap = BiMap.stringInt(data.items.keys)
@@ -86,6 +87,7 @@ class CooccurrenceAlgorithm(val ap:
CooccurrenceAlgorithmParams)
topCooccurrences
}
+ override
def predict(model: CooccurrenceModel, query: Query): PredictedResult = {
// convert items to Int index
diff --git a/src/main/scala/Preparator.scala b/src/main/scala/Preparator.scala
index 8c005f1..d596aa8 100644
--- a/src/main/scala/Preparator.scala
+++ b/src/main/scala/Preparator.scala
@@ -8,6 +8,7 @@ import org.apache.spark.rdd.RDD
class Preparator
extends PPreparator[TrainingData, PreparedData] {
+ override
def prepare(sc: SparkContext, trainingData: TrainingData): PreparedData = {
new PreparedData(
users = trainingData.users,
