jerrypeng commented on a change in pull request #2613: Avoid scheduling
heartbeat function if owner-worker not available
URL: https://github.com/apache/pulsar/pull/2613#discussion_r219728639
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
##########
@@ -241,6 +252,12 @@ private void publishNewAssignment(Assignment assignment,
boolean deleted) {
for (Map.Entry<String, Function.Instance> instanceEntry :
functionInstances.entrySet()) {
String fullyQualifiedInstanceId = instanceEntry.getKey();
Function.Instance instance = instanceEntry.getValue();
+ String heartBeatWorkerId = checkHeartBeatFunction(instance);
+ if (heartBeatWorkerId != null) {
+ resultAssignments
Review comment:
you can probably just exclude/skip the heartbeat function from instead of
using "resultAssignments". Please see my other comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
