rdhabalia commented on a change in pull request #2613: Avoid scheduling
heartbeat function if owner-worker not available
URL: https://github.com/apache/pulsar/pull/2613#discussion_r220114094
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/scheduler/IScheduler.java
##########
@@ -22,9 +22,22 @@
import org.apache.pulsar.functions.proto.Function.Instance;
import java.util.List;
+import java.util.Set;
public interface IScheduler {
- List<Assignment> schedule(List<Instance> unassignedFunctionInstances,
- List<Assignment> currentAssignments,
List<String> workers);
+ /**
+ * Scheduler schedules assignments to appropriate workers and adds into
#resultAssignments
+ *
+ * @param resultAssignments
Review comment:
> why can't you just put the heart beat assignments in a separate list
yes, i wanted to avoid creating garbage (temp maps/lists) if possible at
every place to avoid gc-issues in long run. and if SchedulerManager is anyway
modifying assignments then I don't see any issue for passing the same list to
the sub-sequent chain-processor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
