jerrypeng commented on a change in pull request #2875: Hooked up secrets function api with secret function implementations URL: https://github.com/apache/pulsar/pull/2875#discussion_r228766165
########## File path: pulsar-functions/instance/src/main/python/python_instance_main.py ########## @@ -120,11 +123,23 @@ def main(): if args.tls_trust_cert_path: tls_trust_cert_path = args.tls_trust_cert_path pulsar_client = pulsar.Client(args.pulsar_serviceurl, authentication, 30, 1, 1, 50000, None, use_tls, tls_trust_cert_path, tls_allow_insecure_connection) + + secrets_provider = None Review comment: we should probably start writing unittests for python as well since the unittest framework has been setup ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services