ivankelly commented on a change in pull request #2888: PIP-25: Token based authentication URL: https://github.com/apache/pulsar/pull/2888#discussion_r229325406
########## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ########## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.authentication; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkNotNull; + +import com.google.common.base.Charsets; + +import io.jsonwebtoken.Claims; +import io.jsonwebtoken.Jwt; +import io.jsonwebtoken.JwtException; +import io.jsonwebtoken.Jwts; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Paths; + +import javax.crypto.SecretKey; +import javax.naming.AuthenticationException; + +import lombok.extern.slf4j.Slf4j; + +import org.apache.pulsar.broker.ServiceConfiguration; +import org.apache.pulsar.broker.authentication.utils.AuthTokenUtils; + +@Slf4j +public class AuthenticationProviderToken implements AuthenticationProvider { + + public final static String HTTP_HEADER_NAME = "X-Pulsar-Auth"; + + final static String CONF_TOKEN_SECRET_KEY = "tokenSecretKey"; Review comment: This looks like PSK. We should also have a Public/Private key implementation. With PSK, one compromised broker means that all brokers are compromised. With Public/Private the private key can be kept in an air gapped laptop with it's wifi fried and it's ethernet glued, and only used to generate tokens. Then public keys stored on each broker. If a broker is compromised, you can just take that broker offline. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
