ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered
Storage
URL: https://github.com/apache/pulsar/pull/2865#discussion_r229606299
##########
File path:
tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloaderTest.java
##########
@@ -50,99 +55,83 @@
import org.apache.bookkeeper.client.api.ReadHandle;
import org.apache.bookkeeper.common.util.OrderedScheduler;
import org.apache.bookkeeper.mledger.LedgerOffloader;
-import org.apache.bookkeeper.mledger.offload.jcloud.BlobStoreTestBase;
-import
org.apache.bookkeeper.mledger.offload.jcloud.TieredStorageConfigurationData;
+import org.apache.bookkeeper.mledger.offload.jcloud.provider.BlobStoreLocation;
+import
org.apache.bookkeeper.mledger.offload.jcloud.provider.BlobStoreRepository;
+import
org.apache.bookkeeper.mledger.offload.jcloud.provider.JCloudBlobStoreProvider;
+import
org.apache.bookkeeper.mledger.offload.jcloud.provider.TieredStorageConfiguration;
import org.apache.bookkeeper.util.ZkUtils;
import org.apache.zookeeper.CreateMode;
import org.apache.zookeeper.MockZooKeeper;
import org.apache.zookeeper.data.ACL;
import org.jclouds.blobstore.BlobStore;
+import org.jclouds.blobstore.domain.Blob;
+import org.jclouds.blobstore.domain.BlobBuilder;
import org.jclouds.blobstore.options.CopyOptions;
+import org.jclouds.domain.Credentials;
+import org.jclouds.aws.domain.SessionCredentials;
import org.mockito.Mockito;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.testng.Assert;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
import org.testng.collections.Maps;
-class BlobStoreManagedLedgerOffloaderTest extends BlobStoreTestBase {
+class BlobStoreManagedLedgerOffloaderTest extends
BlobStoreManagedLedgerOffloaderBase {
+
Review comment:
This line, and many other lines in this file have newly added trailing
whitespace.
Shows up in git tools. Checkstyle should really be flagging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
