ivankelly commented on a change in pull request #2935: Ensure broker is fully
boostrapped before load manager register itself
URL: https://github.com/apache/pulsar/pull/2935#discussion_r231030667
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -369,6 +367,13 @@ public void start() throws PulsarServerException {
attributeMap.put(WebService.ATTRIBUTE_PULSAR_NAME, this);
Map<String, Object> vipAttributeMap = Maps.newHashMap();
vipAttributeMap.put(VipStatus.ATTRIBUTE_STATUS_FILE_PATH,
this.config.getStatusFilePath());
+ vipAttributeMap.put(VipStatus.ATTRIBUTE_IS_READY_PROBE, new
Supplier<Boolean>() {
+ @Override
+ public Boolean get() {
+ // Ensure the VIP status is only visible when the broker
is fully initialized
+ return state == State.Started;
Review comment:
state is non-volatile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
