aahmed-se commented on a change in pull request #2957: Add Connect and Read
timeout to pulsar admin
URL: https://github.com/apache/pulsar/pull/2957#discussion_r232844333
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImpl.java
##########
@@ -93,4 +93,16 @@ public PulsarAdminBuilder
enableTlsHostnameVerification(boolean enableTlsHostnam
conf.setTlsHostnameVerificationEnable(enableTlsHostnameVerification);
return this;
}
+
+ @Override
+ public PulsarAdminBuilder setConnectionTimeOutSeconds(int
connectionTimeOutSeconds) {
+ conf.setConnectTimeOutSeconds(connectionTimeOutSeconds);
Review comment:
we can add it there
```
public class PulsarAdminBuilderImpl implements PulsarAdminBuilder {
private long connectTimeOutSeconds = 60;
private long readTimeOutSeconds = 60;
protected final ClientConfigurationData conf;
```
but all the constructors for PulsarAdmin will have to be overridden to take
these two new integer values. I am not sure we wan to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
