sijie closed pull request #3047: Add configs for broker stats update frequency
URL: https://github.com/apache/pulsar/pull/3047
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
index 2a7b16edad..9eba00e893 100644
---
a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
+++
b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
@@ -510,6 +510,8 @@
/**** --- Broker Web Stats --- ****/
// If true, export publisher stats when returning topics stats from the
admin rest api
private boolean exposePublisherStats = true;
+ private int statsUpdateFrequencyInSecs = 60;
+ private int statsUpdateInitailDelayInSecs = 60;
/**** --- Ledger Offloading --- ****/
/****
@@ -1761,6 +1763,22 @@ public boolean isRunningStandalone() {
return isRunningStandalone;
}
+ public int getStatsUpdateFrequencyInSecs() {
+ return statsUpdateFrequencyInSecs;
+ }
+
+ public void setStatsUpdateFrequencyInSecs(int statsUpdateFrequencyInSecs) {
+ this.statsUpdateFrequencyInSecs = statsUpdateFrequencyInSecs;
+ }
+
+ public int getStatsUpdateInitialDelayInSecs() {
+ return statsUpdateInitailDelayInSecs;
+ }
+
+ public void setStatsUpdateInitailDelayInSecs(int
statsUpdateInitailDelayInSecs) {
+ this.statsUpdateInitailDelayInSecs = statsUpdateInitailDelayInSecs;
+ }
+
public void setRunningStandalone(boolean isRunningStandalone) {
this.isRunningStandalone = isRunningStandalone;
}
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
index 01644a6276..725ee93f30 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
@@ -311,7 +311,9 @@ public void start() throws Exception {
}
// start other housekeeping functions
- this.startStatsUpdater();
+ this.startStatsUpdater(
+ serviceConfig.getStatsUpdateInitialDelayInSecs(),
+ serviceConfig.getStatsUpdateFrequencyInSecs());
this.startInactivityMonitor();
this.startMessageExpiryMonitor();
this.startCompactionMonitor();
@@ -321,8 +323,9 @@ public void start() throws Exception {
ClientCnxnAspect.registerExecutor(pulsar.getExecutor());
}
- void startStatsUpdater() {
- statsUpdater.scheduleAtFixedRate(safeRun(this::updateRates), 60, 60,
TimeUnit.SECONDS);
+ void startStatsUpdater(int statsUpdateInitailDelayInSecs, int
statsUpdateFrequencyInSecs) {
+ statsUpdater.scheduleAtFixedRate(safeRun(this::updateRates),
+ statsUpdateInitailDelayInSecs, statsUpdateFrequencyInSecs,
TimeUnit.SECONDS);
// Ensure the broker starts up with initial stats
updateRates();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services