maskit edited a comment on issue #2888: PIP-25: Token based authentication URL: https://github.com/apache/pulsar/pull/2888#issuecomment-441582678 The "data:" parser you wrote would be a duplicate code because it's already implemented in the in-house URL class I wrote. I'm not going to make a change request because I don't want to delay this feature, but either of the parsers should be removed eventually to eliminate duplicate code. Also, because environment variables are general enough as data sources, I think "env:" parser should be added as a `URLStreamHandler` so that other places can use it too via the in-house URL class. As for "token:", I'm ok with having it in this plugin as a special case. But if you renamed it to "raw:", it could be used on other places.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
