srkukarni commented on a change in pull request #3060: Make sure to properly 
count number of processed messages in python
URL: https://github.com/apache/pulsar/pull/3060#discussion_r236518239
 
 

 ##########
 File path: pulsar-functions/instance/src/main/python/python_instance.py
 ##########
 @@ -309,15 +303,12 @@ def get_metrics(self):
     metrics_data = InstanceCommunication_pb2.MetricsData()
     # total metrics
     metrics_data.receivedTotal = int(total_received) if sys.version_info.major 
>= 3 else long(total_received)
-    metrics_data.processedTotal = int(total_processed) if 
sys.version_info.major >= 3 else long(total_processed)
     metrics_data.processedSuccessfullyTotal = 
int(total_processed_successfully) if sys.version_info.major >= 3 else 
long(total_processed_successfully)
     metrics_data.systemExceptionsTotal = int(total_sys_exceptions) if 
sys.version_info.major >= 3 else long(total_sys_exceptions)
     metrics_data.userExceptionsTotal = int(total_user_exceptions) if 
sys.version_info.major >= 3 else long(total_user_exceptions)
     metrics_data.avgProcessLatency = avg_process_latency_ms
     metrics_data.lastInvocation = int(last_invocation) if 
sys.version_info.major >= 3 else long(last_invocation)
     # 1min metrics
-    metrics_data.receivedTotal_1min = int(total_received_1min) if 
sys.version_info.major >= 3 else long(total_received_1min)
 
 Review comment:
   Accidentally removed. Restored back

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to