maskit commented on a change in pull request #2888: PIP-25: Token based authentication URL: https://github.com/apache/pulsar/pull/2888#discussion_r236688651
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationToken.java ########## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pulsar.client.impl.auth; + +import com.google.common.base.Charsets; + +import java.io.IOException; +import java.net.URI; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.Map; +import java.util.function.Supplier; + +import org.apache.pulsar.client.api.Authentication; +import org.apache.pulsar.client.api.AuthenticationDataProvider; +import org.apache.pulsar.client.api.EncodedAuthenticationParameterSupport; +import org.apache.pulsar.client.api.PulsarClientException; + +/** + * Token based authentication provider. + */ +public class AuthenticationToken implements Authentication, EncodedAuthenticationParameterSupport { + + private Supplier<String> tokenSupplier; + + public AuthenticationToken() { + } + + public AuthenticationToken(String token) { + this(() -> token); + } + + public AuthenticationToken(Supplier<String> tokenSupplier) { + this.tokenSupplier = tokenSupplier; + } + + @Override + public void close() throws IOException { + // noop + } + + @Override + public String getAuthMethodName() { + return "token"; + } + + @Override + public AuthenticationDataProvider getAuthData() throws PulsarClientException { + return new AuthenticationDataToken(tokenSupplier); + } + + @Override + public void configure(String encodedAuthParamString) { + // Interpret the whole param string as the token. If the string contains the notation `token:xxxxx` then strip + // the prefix + if (encodedAuthParamString.startsWith("token:")) { Review comment: Why we shouldn't support data: for small data? Even if it's not a suitable scheme, I don't see reasons to drop it. If we allowed using any schemes for any cases and used the URL class to support them, we wouldn't need to maintain this if-else block. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
