merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go
implementation for token authentication
URL: https://github.com/apache/pulsar/pull/3067#discussion_r236889033
##########
File path: pulsar-client-cpp/include/pulsar/Authentication.h
##########
@@ -114,6 +115,43 @@ class AuthTls : public Authentication {
AuthenticationDataPtr authDataTls_;
};
+typedef boost::function<std::string()> TokenSupplier;
Review comment:
Throughout the API we are using `boost::function` (as well as
`boost::shared_ptr`). This comes from the fact that code was initially written
as C++98 compliant.
I believe we should move to C++11 standard (actually C++14 at this point)
and convert all these boost references into std, in one shot.
Regarding this change, I believe we should be consistent with the rest of
API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
