[pulsar] branch master updated: Extra logging for offloaders (#2733)

[ivank]

This is an automated email from the ASF dual-hosted git repository.

ivank pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 4358a98  Extra logging for offloaders (#2733)
4358a98 is described below

commit 4358a98cd8790c549e415dbafc8cc943661b5713
Author: Ivan Kelly <iv...@apache.org>
AuthorDate: Wed Nov 28 17:05:04 2018 +0100

    Extra logging for offloaders (#2733)
    
    Some extra logging for offloader loading and initialization which
    would have been useful when debugging #2697.
---
 .../java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java     | 2 ++
 .../java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java     | 3 ++-
 .../src/main/java/org/apache/pulsar/broker/PulsarService.java          | 1 +
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
index 6083c64..e9b4c90 100644
--- 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
+++ 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -2153,6 +2153,8 @@ public class ManagedLedgerImpl implements ManagedLedger, 
CreateCallback {
                     })
                 .whenComplete((ignore, exception) -> {
                         if (exception != null) {
+                            log.info("[{}] Exception occurred during offload", 
name, exception);
+
                             PositionImpl newFirstUnoffloaded = 
PositionImpl.get(ledgerId, 0);
                             if 
(newFirstUnoffloaded.compareTo(firstUnoffloaded) > 0) {
                                 newFirstUnoffloaded = firstUnoffloaded;
diff --git 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java
 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java
index a1d3349..8726704 100644
--- 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java
+++ 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/offload/OffloaderUtils.java
@@ -114,7 +114,7 @@ public class OffloaderUtils {
 
     public static Offloaders searchForOffloaders(String connectorsDirectory) 
throws IOException {
         Path path = Paths.get(connectorsDirectory).toAbsolutePath();
-        log.info("Searching for connectors in {}", path);
+        log.info("Searching for offloaders in {}", path);
 
         Offloaders offloaders = new Offloaders();
 
@@ -142,6 +142,7 @@ public class OffloaderUtils {
                 }
             });
         }
+        log.info("Found and loaded {} offloaders", 
offloaders.getOffloaders().size());
         return offloaders;
     }
 
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
index 8925c07..195f4d5 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
@@ -710,6 +710,7 @@ public class PulsarService implements AutoCloseable {
                     throw new PulsarServerException(ioe.getMessage(), 
ioe.getCause());
                 }
             } else {
+                LOG.info("No ledger offloader configured, using NULL 
instance");
                 return NullLedgerOffloader.INSTANCE;
             }
         } catch (Throwable t) {