jerrypeng commented on a change in pull request #3088: Improve and correct status for function, sources, sinks URL: https://github.com/apache/pulsar/pull/3088#discussion_r237335424
########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java ########## @@ -39,8 +39,8 @@ import org.apache.pulsar.client.api.Message; import org.apache.pulsar.common.io.ConnectorDefinition; import org.apache.pulsar.common.policies.data.FunctionStats; +import org.apache.pulsar.common.policies.data.FunctionStatus; Review comment: @srkukarni all other classes in pulsar used to define the structure of return messages are placed here. FunctionConfig/SourceConfig/SinkConfig are used to define function as well as a return message to "get function" not sure if thats totally appropriate but that another discussion ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
