erenavsarogullari commented on a change in pull request #3190: [Pulsar-Flink] Add Batch Sink Scala Examples Documentation URL: https://github.com/apache/pulsar/pull/3190#discussion_r241881694
########## File path: pulsar-flink/src/test/scala/org/apache/flink/batch/connectors/pulsar/example/README.md ########## @@ -0,0 +1,262 @@ +The Flink Batch Sink for Pulsar is a custom sink that enables Apache [Flink](https://flink.apache.org/) to write [DataSet](https://ci.apache.org/projects/flink/flink-docs-stable/dev/batch/index.html) to Pulsar. Review comment: @sijie Both `Java` and `Scala` Flink Examples have been moved under `/examples/flink-consumer-source` I think, as current patch, `single Flink example sub-module` can cover all Flink related examples. On the other hand, Batch and Streaming Documentations can also be aligned. Plan to address via separated PR if there is no concern. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
