sijie commented on a change in pull request #3240: timeout stuck
producer/consumer operation request
URL: https://github.com/apache/pulsar/pull/3240#discussion_r243920604
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
##########
@@ -668,6 +668,15 @@ SocketAddress serverAddrees() {
future.completeExceptionally(writeFuture.cause());
}
});
+ eventLoopGroup.schedule(() -> {
Review comment:
I have a performance related concern:
1) this would be scheduled per request. so it would end up with a lot of
timeout tasks, no?
2) there is no mechanism to cancel the timeout tasks. so all tasks will be
remaining until they are timed out, no?
Can we change the approach to have one timer task that peridocally check the
pending requests list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
