maskit commented on issue #3252: [dev] PIP 27: Add checklist in github pull 
request template
URL: https://github.com/apache/pulsar/pull/3252#issuecomment-450135707
 
 
   > because not every code change requires documentation. Most of code changes 
don't require documentation, e.g. bug fixes, and tasks for a large features.
   
   > If a change is changing any item under "Does this pull request potentially 
affect one of the following parts", this change is most likely required to have 
related documentation change.
   
   Thanks for the clarification. I understand the policy and I'm fine with it. 
However, the questions in Documentation section might be confusing a little if 
that is the policy.
   
   >   - Does this pull request introduce a new feature? (yes / no)
   >   - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)
   
   These questions imply that you can say "yes, but it's not documented". There 
would be cases we accept as exceptions so it's a valid answer, but I'm not sure 
we should show such a option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to